[Webkit-unassigned] [Bug 34716] audio engine: audio output classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34716





--- Comment #12 from Chris Rogers <crogers at google.com>  2010-09-14 13:18:08 PST ---
> Why are you including RefCounted here if not using the type in this header?

Turns out this wasn't necessary - I removed this line.


>Should AudioSourceProvider be made RefCounted and this use PassRefPtr<AudioSourceProvider>?

The ownership is in the other direction.  In actual usage, the AudioSourceProvider subclass  creates and owns the AudioDestination.  Also,  AudioSourceProvider is an abstract base class and it adds complications to inherit from RefCounted, since other subclasses define their own versions of ref() / deref()...


>No semicolon.
fixed

> Prefer early return; e.g. here, "if (result) return 0.0;".
fixed

> This looks like a hack. Is it really necessary?
Yes, you're right.  It turns out the usleep() is not necessary since AudioOutputUnitStop() waits for the audio thread to complete before returning.  I've removed this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.