[Webkit-unassigned] [Bug 41510] Add Base64DecodePolicy option at base64Decode()

Tue Sep 14 09:34:32 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=41510

--- Comment #42 from Darin Adler <darin at apple.com>  2010-09-14 09:34:32 PST ---
(In reply to comment #40)
> > The idea of not setting the user style sheet if the locationString is nil is a little strange. Maybe setting it to the empty string or removing the preference setting entirely would be appropriate.
> I have no knowledge of ObjC :-/. Can you post me a snippet for the patch?

I know lots about Objective-C, but I’m not sure this truly is an Objective-C question. Here are the questions we need to answer to get the code right:

Under what circumstances can locationString end up nil? What is the best behavior for the API in that case? Is this a change from the behavior of the existing code?

Once we answer those I can advise on how to write the code. It may be that your early exit is the right thing to do. By the way, in WebKit we normally use a coding style called early return so a version that uses return rather than nesting the _setStringValue call inside an if would be our preferred style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.