[Webkit-unassigned] [Bug 45669] ARMv7Assembler generates illegal instructions with RVCT

Tue Sep 14 09:23:13 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45669

--- Comment #10 from Gabor Loki <loki at webkit.org>  2010-09-14 09:23:13 PST ---
> Did you try changing your memory allocator to hand out 0xff memset memory? You likely should hit it right away. Also you can inspect the asm generated by both and you'll see the difference. 

No, but I see the problem.

> The reason I didn't make these changes because it doesn't match the method names. hi4 --> 4 bits. hi4 member --> 4 bits.. 

Probably this was a wrong naming-convention. The shifts and rotates are encoded into 2 type bits and 5 immediate bits for immediate shifts and rotates (in both ARM and Thumb-2 instruction set cases). It is maybe misleading that those Thumb-2 instructions where an immediate shift can be applied contain a zero in the 15th bit place (right above the imm3 part of shift value). So, the hi4 should be a hi3 in this case.

> And this asInt style was used throughout the file as well to memset unions that don't fill out all the bits as well. Look at ThumbImmediateValue...

Well, those asInt members are not just standing there for initialization/clearing unused bits. You can set and get value through asInt. ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.