[Webkit-unassigned] [Bug 45446] [EFL] Add setting API to set a local storage database path.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45446





--- Comment #9 from Rafael Antognolli <antognolli at profusion.mobi>  2010-09-14 06:29:39 PST ---
(In reply to comment #8)
> > Another point is: do you know what's the default value for the database path? If it's not empty, then you need to set it in the settings->local_storage_database_path during the ewk_view creation too, so they won't have different and thus inconsistent values. This is done in _ewk_view_priv_new(). There you also can set a default path if there's none yet.
> 
> I don't find if there is default database path until now. I continue to find if there is a default database path in webkit. If there are no default database path. IMO, we can set default database path. However, as you know, EWebLauncher defines database path. And, the database path can be changed according to user id.
> 
> 832     tmp = getenv("TMPDIR");
> 833     if (!tmp)
> 834         tmp = "/tmp";
> 835     snprintf(path, sizeof(path), "%s/.ewebkit-%u", tmp, getuid());
> 
> So, default database path will be changed by EWebLauncher. Ok, I look this into further. Them, I will post my thought here again. Thanks.

Ok, that's not a problem, you can initialise it in EWebLauncher. But in _ewk_view_priv_new() it would be good to have something like:

s = priv->page_settings->localStorageDatabasePath();
priv->settings.local_storage_database_path = eina_stringshare_add(s.utf8().data());

I just checked the default value of priv->page_settings->localStorageDatabasePath(), and it defaults to "". So it would be good to make sure that it makes sense to have enabled local storage, without a local storage database path set. If it doesn't, then maybe we should disable local storage by default.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.