[Webkit-unassigned] [Bug 45732] [Qt] DumpRenderTreeSupportQt::suspendActiveDOMObjects needs a new parameter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 13 21:22:43 PDT 2010


--- Comment #5 from Daniel Bates <dbates at webkit.org>  2010-09-13 21:22:43 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 67517 [details] [details])
> > LGTM.
> > r=me
> I am assuming WebCore/dom/ActiveDOMObject.h gets included by someone...

So, it will get included by WorkerThread.h, which includes WorkerRunLoop.h  which includes ScriptExecutionContext.h, which includes ActiveDOMObject.h

I was a bit to quick when reviewing this. The enum value JavaScriptPaused was renamed to JavaScriptDebuggerPaused. I missed that in the review. My mistake.

I will be more cautious.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list