[Webkit-unassigned] [Bug 45560] Expose an entry point to Chrome for scrolling portions of the page

Mon Sep 13 15:24:47 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45560

WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com

--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-09-13 15:24:47 PST ---
Attachment 67479 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/tests/GestureScrollTest.cpp:33:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/GestureScrollTest.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/GestureScrollTest.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/GestureScrollTest.cpp:63:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebKit/chromium/tests/GestureScrollTest.cpp:64:  Missing space after ,  [whitespace/comma] [3]
WebKit/chromium/tests/GestureScrollTest.cpp:66:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
WebKit/chromium/tests/GestureScrollTest.cpp:78:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit/chromium/tests/GestureScrollTest.cpp:79:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit/chromium/tests/GestureScrollTest.cpp:81:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit/chromium/tests/GestureScrollTest.cpp:82:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit/chromium/tests/GestureScrollTest.cpp:83:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit/chromium/tests/GestureScrollTest.cpp:84:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit/chromium/tests/GestureScrollTest.cpp:85:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit/chromium/tests/GestureScrollTest.cpp:104:  Missing space after ,  [whitespace/comma] [3]
WebKit/chromium/tests/GestureScrollTest.cpp:105:  Missing space after ,  [whitespace/comma] [3]
WebKit/chromium/src/WebPopupMenuImpl.cpp:127:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 16 in 12 files

If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.