[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66367|0                           |1
        is obsolete|                            |
  Attachment #67463|                            |review?
               Flag|                            |




--- Comment #75 from Mario Sanchez Prada <msanchez at igalia.com>  2010-09-13 13:16:21 PST ---
Created an attachment (id=67463)
 --> (https://bugs.webkit.org/attachment.cgi?id=67463)
Single patch for fixing this bug

(In reply to comment #74)
> [...] 
> Thanks Enrica, that's just what I needed. As soon as I finish addressing other issues in other patches I'll try this out.

I'm now attaching a new patch addressing all the issues you (Enrica) pointed out so I hope this new patch to be better and, hopefully, closer to help fixing this bug :-)

Wrt the calculateGlobalOffset() function you (Enrica) were definitely right: I was messing too much with a loop iterating over nodes while TextIterator::rangeLength() would basically do everything I needed in a way better and cleaner fashion. Hence I removed that function in this new patch and just added the three-line code in the only place it was needed.

So, now asking for review once again. Hopefully this will be the last or one of the last times I bother you all with this stuff :-) Anyway, don't hesitate to ask whatever you want, of course.

PS: If you review+ it, please set the cq+ flag as well. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.