[Webkit-unassigned] [Bug 45071] Only intercept ESC key press when autocorrection UI is visible.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45071


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67441|review?                     |review-
               Flag|                            |




--- Comment #6 from mitz at webkit.org  2010-09-13 11:38:05 PST ---
(From update of attachment 67441)
View in context: https://bugs.webkit.org/attachment.cgi?id=67441&action=prettypatch

> WebCore/editing/EditorCommand.cpp:1130
> +static bool supportedDismissCorrectionPanel(Frame* frame, EditorCommandSource source)
> +{
> +    if (supportedFromMenuOrKeyBinding(frame, source))
> +        return frame->editor()->isShowingCorrectionPanel();
> +    return false;
> +}
Personally, I would write this as
    return supportedFromMenuOrKeyBinding(frame, source) && frame->editor()->isShowingCorrectionPanel();

> WebKit/mac/WebCoreSupport/WebEditorClient.mm:842
> +bool WebEditorClient::isShowingCorrectionPanel() {
> +    return m_correctionPanelTag != InvalidCorrectionPanelTag;
> +}
The opening brace should go on its own line.

r- so you can fix that style issue and consider the other comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.