[Webkit-unassigned] [Bug 44127] [chromium] Thumbnails not generated for GPU Rendered Pages

Mon Sep 13 11:31:05 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=44127

Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67419|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #73 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-09-13 11:31:05 PST ---
(From update of attachment 67419)
View in context: https://bugs.webkit.org/attachment.cgi?id=67419&action=prettypatch

> WebKit/chromium/src/WebViewImpl.cpp:980
> +    OwnPtr<ImageBuffer> imgBuffer(ImageBuffer::create(rect.size()));
nit: imgBuffer -> imageBuffer, imgData -> imageData

webkit style prefers spelling out variable names

> WebKit/chromium/src/WebViewImpl.cpp:1006
> +            IntRect resizeRect(rect.x, rect.y, rect.width, rect.height);
nit: you can also just write:  IntRect resizeRect(rect);

there is an implicit conversion operator from WebRect to IntRect

R=me otherwise

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.