[Webkit-unassigned] [Bug 45687] [GTK] Code simplification needed in Atk Wrapper

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 13 11:09:08 PDT 2010


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
  Attachment #67433|                            |review?, commit-queue?
               Flag|                            |

--- Comment #1 from Mario Sanchez Prada <msanchez at igalia.com>  2010-09-13 11:09:08 PST ---
Created an attachment (id=67433)
 --> (https://bugs.webkit.org/attachment.cgi?id=67433)
Patch to fix this issue

Attaching a patch to fix this "issue" by simplifying the code as expected:

  Use TextIterator::rangeLength() to calculate endOffset

     * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
     (getSelectionOffsetsForObject): Don't manually iterate over a
     artificial new range but just call TextIterator::rangeLength on
     the range created between the start and end positions.

Hence, asking for review (and for the cq+ flag as well ;-)

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list