[Webkit-unassigned] [Bug 43988] Web Inspector: Remote Web Inspector support for QtWebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43988


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67401|review?                     |review-
               Flag|                            |




--- Comment #21 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-09-13 09:09:40 PST ---
(From update of attachment 67401)
View in context: https://bugs.webkit.org/attachment.cgi?id=67401&action=prettypatch

> WebKit/qt/Api/qwebinspector_p.h:40
> +    void attachRemoteFrontend(QObject* newRemoteFrontend);
so it actually substitutes it? attachAndReplaceFrontend?

> WebKit/qt/ChangeLog:15
> +            http://localhost:9222/devtools/page/1
Couldn't http://localhost:9222/devtools redirect to page/1 or so automatically?

> WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:129
> +    // remote frontend was attached
Comments start with capital and end with dot.

> WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:44
> +static void setChallengeNumber(unsigned char* buf, uint32_t number)
Maybe add a comment on what it does on top

> WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:67
> +static quint32 getChallengeNumberFromField(QString field)
parseChallengeNumber?

> WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:88
> +    // sServer is deleted in unregisterClient() when the last client is unregistered.
sServer? Badly named variable

> WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:144
> +        sServer = 0;
Who is responsible for freeing this?

> WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:335
> +        size_t length = pos - 1;
Is pos always > 0 here? Comment

> WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:344
> +        m_data = m_data.mid(length + 2);
comment about the + 2

> WebKit/qt/WebCoreSupport/InspectorServerQt.cpp:354
> +bool RemoteFrontendChannel::sendMessageToFrontend(const String &message)
& is placed wrongly

> WebKit/qt/WebCoreSupport/InspectorServerQt.h:50
> +    InspectorClientQt* inspectorClient(int pageNum);
inspectorClientForPageId or something similar?

> WebKit/qt/WebCoreSupport/InspectorServerQt.h:107
> +
This newline is not needed here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.