[Webkit-unassigned] [Bug 45673] Regression r65596 - Stack not 8 byte aligned

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 13 08:12:15 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=45673


David Tapuska <dtapuska at rim.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67411|                            |review?, commit-queue?
               Flag|                            |




--- Comment #1 from David Tapuska <dtapuska at rim.com>  2010-09-13 08:12:14 PST ---
Created an attachment (id=67411)
 --> (https://bugs.webkit.org/attachment.cgi?id=67411)
Ensure ENABLE_PROFILER_REFERENCE_OFFSET is divisible by 8

This change adjusts the padding in the struct. In r65596 the padding that was there for JSVALUE32_64 was made useless because the object would be 8 byte aligned already so it can be removed. The additional padding that was essentially used for making sure the enabledProfilerReference offset was 8 byte aligned for JSVALUE32 was moved ahead so that we remove this padding for JSVALUE32_64 and have the correct field alignments for the rest. One benefit of this change (aside from fixing the bug) is that it reduces the JITStackFrame by 12 bytes by removing useless padding.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list