[Webkit-unassigned] [Bug 45114] Web Inspector: show status message below call stack when debugger is paused

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45114


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67388|review?                     |review-
               Flag|                            |




--- Comment #12 from Pavel Feldman <pfeldman at chromium.org>  2010-09-13 05:18:23 PST ---
(From update of attachment 67388)
View in context: https://bugs.webkit.org/attachment.cgi?id=67388&action=prettypatch

Overall looks good.

> WebCore/inspector/front-end/CallStackSidebarPane.js:89
> +        var breakpointOwnerLink = WebInspector.panels.elements.linkifyNodeReference(breakpointOwnerNode);
breakpointOwnerNode can be undefined here.

> WebCore/inspector/front-end/CallStackSidebarPane.js:96
> +            var targetNodeLink = WebInspector.panels.elements.linkifyNodeReference(targetNode);
Ditto.

> WebCore/inspector/front-end/CallStackSidebarPane.js:99
> +                    format = WebInspector.UIString("Paused on a \"%s\" breakpoint set on %s, because a new child was added to its descendant %s.");
Nit: I'd introduce WebInspector.formatLocalized beside UIString instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.