[Webkit-unassigned] [Bug 45393] WebKitTestRunner should be portable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45393





--- Comment #9 from Balazs Kelemen <kb at inf.u-szeged.hu>  2010-09-13 02:45:55 PST ---
> 
> This looks good to me, thanks for doing this.  I don't think all the inlining is necessary though. I also don't know what you mean about the CFRunLoop. Can you elaborate on that or point to the code you are talking about?

I see other CF uses mostly in InjectedBundle/LayoutTestController.cpp, for example: http://trac.webkit.org/browser/trunk/WebKitTools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp#L116

Inlining could be avoided by using the same files for WTR and InjectedBundle. Do you thing it would be ok? Moreover we could introducing a new static lib target for those files or duplicate them. Which solution do you vote for?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.