[Webkit-unassigned] [Bug 45572] WebAccessibilityCacheImpl needs to handle invalid accessibility object ids

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45572


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67285|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #7 from chris fleizach <cfleizach at apple.com>  2010-09-12 20:03:13 PST ---
(From update of attachment 67285)
> Index: WebKit/chromium/ChangeLog
> ===================================================================
> --- WebKit/chromium/ChangeLog	(revision 67263)
> +++ WebKit/chromium/ChangeLog	(working copy)
> @@ -1,3 +1,16 @@
> +2010-09-10  Chris Guillory  <chris.guillory at google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        WebAccessibilityCacheImpl needs to handle invalid accessibility object ids

period at end of sentence
> +    WEBKIT_API bool isAxObjectIdValid() const;

since this is inside of an ax object, the method name should probably just be "isIdValid()"

>  
>      WEBKIT_API unsigned childCount() const;
>  
> +bool WebAccessibilityObject::isAxObjectIdValid() const
> +{
> +    if (!m_private)
> +        return false;
> +
> +    m_private->updateBackingStore();

after calling updateBackingStore() it's possible that m_private will be invalidated (on the WebCore side at least, where it's called m_object). 
you should probably confirm that the object is still valid after calling this method

> +    return m_private->axObjectID();
> +}
> +

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.