[Webkit-unassigned] [Bug 39672] Make sure skia is not Chromium specific

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39672





--- Comment #29 from Kwang Yul Seo <kwangyul.seo at gmail.com>  2010-09-12 16:44:45 PST ---
(In reply to comment #28)
> (From update of attachment 67199 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67199&action=prettypatch
> 
> I'm not so sure about this one - the file still is clearly Chromium specific (it directly uses ChromiumBridge for one) and isn't really more skia specific than linux specific.  Moving a chromium-specific file from /chromium to /skia seems like it would be a regression for your purposes, no?

Yes, you are right. FontCache::getFontDataForCharacters replies on ChromiumBridge. In Brew MP, I changed the method:


const SimpleFontData* FontCache::getFontDataForCharacters(const Font& font,
                                                          const UChar* characters,
                                                          int length)
{
    return font.primaryFont();
}


Except for this method, there is no chromium specific code. I will submit the patch again after separating Chromium specific code. Thanks for your review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.