[Webkit-unassigned] [Bug 45594] Add AtomicString::fromUTF8

Sun Sep 12 12:43:54 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45594


--- Comment #9 from Patrick R. Gansterer <paroga at paroga.com>  2010-09-12 12:43:54 PST ---
(In reply to comment #8)
> > XMLParser will uses the version witout a explicit length most of the time. Ther we can calcualte the hash, utf8length and utf16 length in one step:
> 
> The code you quote below isn't in the patch...  If that's what we're aiming for, why not include that now?
It requires many other changes and I want to be able to create a patch for the XMLParser.

> > This will avoid unnecessary operations, but requires additonal changes to the stringHash and UTF8 functions.
> > I'd like to commit this in a first step to start using the "new API" in XMLParser.
> 
> I guess I still don't understand why any of this is specific to AtomicString.  What we saving by putting these methods on AtomicString and not just on String?
HashAndUTF8CharactersTranslator is a new class which can operate directly with the utf8 characters. We don't need to convert it to utf16 for lookup in the HashTable (this will be the real performance win).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.