[Webkit-unassigned] [Bug 45604] Add callback mechanism for the getting the source of a frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45604


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67321|review?                     |review+
               Flag|                            |




--- Comment #4 from mitz at webkit.org  2010-09-11 18:13:16 PST ---
(From update of attachment 67321)
View in context: https://bugs.webkit.org/attachment.cgi?id=67321&action=prettypatch

> WebKit2/UIProcess/WebPageProxy.cpp:1177
> +    Vector<RefPtr<FrameSourceCallback> > frameSourceCallbacks;
> +    copyValuesToVector(m_frameSourceCallbacks, frameSourceCallbacks);
> +    m_frameSourceCallbacks.clear();
> +    for (size_t i = 0, size = frameSourceCallbacks.size(); i < size; ++i)
> +        frameSourceCallbacks[i]->invalidate();
> +
Consider factoring common code out of processDidExit() and close().

> WebKit2/UIProcess/WebPageProxy.h:82
>  typedef GenericCallback<WKStringRef, WTF::StringImpl*> RenderTreeExternalRepresentationCallback;
>  typedef GenericCallback<WKStringRef, WTF::StringImpl*> ScriptReturnValueCallback;
> +typedef GenericCallback<WKStringRef, WTF::StringImpl*> FrameSourceCallback;
>  
Maybe keep these sorted?

> WebKit2/UIProcess/WebPageProxy.h:243
>  
>      void didReceiveEvent(WebEvent::Type);
> +
>      void didRunJavaScriptInMainFrame(const WTF::String&, uint64_t);
Why the new newline?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.