[Webkit-unassigned] [Bug 45522] Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45522





--- Comment #16 from Sam Weinig <sam at webkit.org>  2010-09-10 17:53:28 PST ---
(In reply to comment #15)
> (From update of attachment 67229 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67229&action=prettypatch
> 
> > WebKit/chromium/src/WebViewImpl.cpp:1489
> > +    if (oldZoomFactor != zoomFactor && textOnly != m_zoomTextOnly) {
> shouldn't this be an OR?  if either the zoom factor or the textOnly flag changes, we need to notify the plugin.

(In reply to comment #15)
> (From update of attachment 67229 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67229&action=prettypatch
> 
> > WebKit/chromium/src/WebViewImpl.cpp:1489
> > +    if (oldZoomFactor != zoomFactor && textOnly != m_zoomTextOnly) {
> shouldn't this be an OR?  if either the zoom factor or the textOnly flag changes, we need to notify the plugin.

Yeah. It should. Is the rest of the patch ok?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.