[Webkit-unassigned] [Bug 45237] Add JSON parameter support to JS/V8 binding generator scripts

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 10 13:00:15 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=45237





--- Comment #6 from Kinuko Yasuda <kinuko at chromium.org>  2010-09-10 13:00:15 PST ---
(In reply to comment #5)
> Attachment 67223 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
> Last 3072 characters of output:
>   Use 0 instead of NULL.  [readability/null] [5]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:199:  webkit_dom_test_json_obj_set_property is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:199:  prop_id is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:206:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:227:  webkit_dom_test_json_obj_get_property is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:227:  prop_id is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:234:  Non-label code inside switch statements should be indented.  [whitespace/indent] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:266:  webkit_dom_test_json_obj_constructed is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:273:  webkit_dom_test_json_obj_class_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:275:  Declaration has space between type name and * in GObjectClass *gobjectClass  [whitespace/declaration] [3]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:326:  webkit_dom_test_json_obj_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:341:  Extra space between return and WEBKIT_DOM_TEST_JSON_OBJ  [whitespace/declaration] [3]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.cpp:342:  Use 0 instead of NULL.  [readability/null] [5]
> WebCore/bindings/scripts/test/V8/V8TestJSONObj.h:26:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
> WebCore/bindings/scripts/test/CPP/WebDOMTestJSONObj.cpp:30:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.h:27:  Alphabetical sorting problem.  [build/include_order] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.h:39:  parent_instance is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.h:43:  parent_class is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WebCore/bindings/scripts/test/GObject/WebKitDOMTestJSONObj.h:47:  Extra space before ( in function call  [whitespace/parens] [4]
> Total errors found: 37 in 21 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

All of them are for generated code.  (I don't know how to suppress them...)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list