[Webkit-unassigned] [Bug 45550] [GTK] Placement new / manual destructor invocation should be used on private GObject memory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45550


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67200|review?                     |review+
               Flag|                            |




--- Comment #2 from Xan Lopez <xan.lopez at gmail.com>  2010-09-10 10:57:48 PST ---
(From update of attachment 67200)

>-    if (priv->tooltipText) {
>-        gtk_tooltip_set_text(tooltip, priv->tooltipText);
>+    if (priv->tooltipText.length() > 0) {

Mmm, should use isEmpty() for consistency sake?

>+        gtk_tooltip_set_text(tooltip, priv->tooltipText.data());
>         return TRUE;
>     }
> 


Looks great otherwise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.