[Webkit-unassigned] [Bug 45528] Move JavaScriptCore statistics gathering into JavaScriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45528


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67166|review?                     |review+
               Flag|                            |




--- Comment #3 from Alexey Proskuryakov <ap at webkit.org>  2010-09-10 08:53:20 PST ---
(From update of attachment 67166)
Oops!

> +#include "ExecutableAllocator.h"
> +#include "JSGlobalData.h"
> +#include "RegisterFile.h"
> +
> +

Extra blank line here.

> +namespace JSC {
> +
> +    MemoryStatistics memoryStatistics(JSGlobalData* commonGlobalData) 

This shouldn't be indented.

I think that it's nice to put heap and stack/JIT statistics under a common umbrella. But I don't think that it's good to report both global and per-heap statistics via one call. Can it be split in two?

> +namespace JSC {
> +
> +    struct MemoryStatistics {

This shouldn't be indented.

> +    MemoryStatistics mStats = memoryStatistics(JSDOMWindow::commonJSGlobalData());

We prefer to not abbreviate words - and "m" is a prefix for member variables!

r=me, since we need to fix the build ASAP, but I think that this can be improved a bit later.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.