[Webkit-unassigned] [Bug 39617] [GTK] Google sites do not like WebKitGTK+

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39617


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67187|review?                     |review+
               Flag|                            |




--- Comment #42 from Martin Robinson <mrobinson at webkit.org>  2010-09-10 08:41:27 PST ---
(From update of attachment 67187)
View in context: https://bugs.webkit.org/attachment.cgi?id=67187&action=prettypatch

> WebKit/gtk/webkit/webkitwebsettings.cpp:-194
> -    if (uname(&name) != -1)
Hrm. I think it's slightly weird to not use the un-ifdef'd return here. Perhaps change this to:
if (uname(&name) != -1)
    uaOSVersion = String::format("%s %s", name.sysname, name.machine);
else
    uaOSVersion = String("Unknown");

Looks good! r=me with this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.