[Webkit-unassigned] [Bug 45498] [FileSystem] Do not call EntriesCallback more than once if there're no entries.

Thu Sep 9 23:00:35 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45498

Dumitru Daniliuc <dumi at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67103|review?                     |review+
               Flag|                            |

--- Comment #2 from Dumitru Daniliuc <dumi at chromium.org>  2010-09-09 23:00:35 PST ---
(From update of attachment 67103)
View in context: https://bugs.webkit.org/attachment.cgi?id=67103&action=prettypatch

r=me, but please address the comments before submitting.

> WebCore/fileapi/FileSystemCallbacks.cpp:150
> +        if (!hasMore && hadEntries) {
i don't think you need the hadEntries variable. can you just use: if (!hasMore && !m_entries->isEmpty()) and clear m_entries after the if-block?

> WebCore/fileapi/FileSystemCallbacks.cpp:151
>              // If there're no more entries, call back once more with an empty array.
update the comment please.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.