[Webkit-unassigned] [Bug 45369] Need to check the target frame and restore the right gesture state during the asynchronous history navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45369





--- Comment #5 from Adam Barth <abarth at webkit.org>  2010-09-09 21:19:07 PST ---
(From update of attachment 66889)
View in context: https://bugs.webkit.org/attachment.cgi?id=66889&action=prettypatch

> WebCore/loader/FrameLoader.cpp:296
> +    // Check whether a new window is allowed to create for navigation.
> +    Frame* targetFrame = m_frame->tree()->find(target);
> +    if (!targetFrame && !DOMWindow::allowPopUp(m_frame) && !isProcessingUserGesture())
> +        return;
It's lame that we need to find the targetFrame again.  What if we get a different answer the second time?  Can we move this check closing to where we actually know the targetFrame?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.