[Webkit-unassigned] [Bug 34716] audio engine: audio output classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34716





--- Comment #10 from Kenneth Russell <kbr at google.com>  2010-09-09 15:49:06 PST ---
(From update of attachment 65748)
View in context: https://bugs.webkit.org/attachment.cgi?id=65748&action=prettypatch

This generally looks fine overall, but I have a couple of questions before adjusting the r? status.

> WebCore/platform/audio/AudioDestination.h:34
> +#include <wtf/RefCounted.h>
Why are you including RefCounted here if not using the type in this header?

> WebCore/platform/audio/AudioDestination.h:45
> +    static PassOwnPtr<AudioDestination> create(AudioSourceProvider&, double sampleRate);
Should AudioSourceProvider be made RefCounted and this use PassRefPtr<AudioSourceProvider>?

> WebCore/platform/audio/AudioDestination.h:47
> +    virtual ~AudioDestination() { };
No semicolon.

> WebCore/platform/audio/mac/AudioDestinationMac.cpp:56
> +    if (!result) {
Prefer early return; e.g. here, "if (result) return 0.0;".

> WebCore/platform/audio/mac/AudioDestinationMac.cpp:148
> +    usleep(4000); // Allow device to actually stop.
This looks like a hack. Is it really necessary?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.