[Webkit-unassigned] [Bug 36475] audio engine: add AudioFileReader files (Mac implementation)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36475


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #65750|review?                     |review-
               Flag|                            |




--- Comment #8 from Kenneth Russell <kbr at google.com>  2010-09-09 15:25:34 PST ---
(From update of attachment 65750)
View in context: https://bugs.webkit.org/attachment.cgi?id=65750&action=prettypatch

This basically looks fine to me but I have a couple of questions, plus one relatively tiny requested movement of one line of code.

> WebCore/platform/audio/mac/AudioFileReaderMac.cpp:37
> +#include <Carbon/Carbon.h>
Is it kosher to be adding dependencies on Carbon at this point? Does this code build in 64-bit mode?

> WebCore/platform/audio/mac/AudioFileReaderMac.cpp:44
> +    UInt32 bufferListSize = sizeof(AudioBufferList) - sizeof(AudioBuffer);
Why can't bufferListSize use a more standard type like size_t?

> WebCore/platform/audio/mac/AudioFileReaderMac.cpp:193
> +    AudioFloatArray bufR(numberOfFrames);
It would be nice if there were a way to avoid allocating these if we aren't mixing the input down to mono.

> WebCore/platform/audio/mac/AudioFileReaderMac.cpp:225
> +    float* destL = audioBus->channel(0)->data();
This variable declaration should be enclosed in the following if block.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.