[Webkit-unassigned] [Bug 44127] [chromium] Thumbnails not generated for GPU Rendered Pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44127





--- Comment #67 from Vangelis Kokkevis <vangelis at chromium.org>  2010-09-09 14:02:39 PST ---
(From update of attachment 67085)
View in context: https://bugs.webkit.org/attachment.cgi?id=67085&action=prettypatch

> WebKit/chromium/src/WebViewImpl.cpp:971
> +    // Compute rect to sample from in inverted GPU buffer.
typo: in inverted

> WebKit/chromium/src/WebViewImpl.cpp:972
> +    IntRect invertRect(rect.x(), bitmapHeight - (rect.y() + rect.height()), rect.width(), rect.height());
rect.y + rect.height I believe is returned by rect.bottom() .  I'm curious though, isn't adding a Y offset here equivalent to some gc.translate further down?  It seems that you would only need one of the two, with the appropriate values. I'd venture to say maybe replace your current gc.translate by a gc.translate(FloatSize(0, rect.bottom())  but use the original rect?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.