[Webkit-unassigned] [Bug 45092] [chromium] Accelerated Compositing: screen garbage when scrolling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45092


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66961|review?                     |review-
               Flag|                            |




--- Comment #26 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-09-09 09:50:35 PST ---
(From update of attachment 66961)
View in context: https://bugs.webkit.org/attachment.cgi?id=66961&action=prettypatch

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:275
> +    // ASSERT(static_cast<int>(CGBitmapContextGetWidth(m_rootLayerCGContext.get())) == updateRect.width() && static_cast<int>(CGBitmapContextGetHeight(m_rootLayerCGContext.get())) == updateRect.height());
is there a reason for commenting out this assertion?  should it just be deleted instead?

> WebKit/chromium/ChangeLog:15
> +        a pair of methods: paintComposited and
this ChangeLog needs to be revised to correspond to the actual name
of the methods.  you should probably just regenerate it completely
as the list of methods below is also out of date.

> WebKit/chromium/src/WebViewImpl.cpp:956
> +        doComposite(canvas);
it's not clear why doComposite needs a canvas parameter if wjmaclean's
readback code is going to go below here.

> WebKit/chromium/src/WebViewImpl.cpp:2311
> +void WebViewImpl::doComposite(WebCanvas* canvas)
i'm pretty sure this canvas parameter can be deleted now.

Looking great overall.  Just these few minor issues remaining.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.