[Webkit-unassigned] [Bug 45134] Added statistics sampling and reporting for JavaScriptCore's RegisterFile and ExecutableAllocator classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45134


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66982|review?                     |review+
               Flag|                            |




--- Comment #14 from Alexey Proskuryakov <ap at webkit.org>  2010-09-09 09:42:55 PST ---
(From update of attachment 66982)
> +        void addToCommittedByteCount(size_t byteCount);

The argument name is not needed here, it doesn't add any information. I'm not sure if this is going to build with all compilers - you pass intptr_t to this function, so there is a suspicious signed to unsigned conversion. It's also confusing that this function takes a size_t, but is frequently called with negative values. I think that the argument can be a long.

> +static FixedVMPoolAllocator* allocator = 0; 

There is a stray space at the end of the line.

Looks good to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.