[Webkit-unassigned] [Bug 45460] Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45460


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #67039|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Jeremy Orlow <jorlow at chromium.org>  2010-09-09 09:04:46 PST ---
(From update of attachment 67039)
View in context: https://bugs.webkit.org/attachment.cgi?id=67039&action=prettypatch

> WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1397
> +    if (arguments.size() < 6 || !arguments[0].isBool() || !arguments[1].isNumber()
not sure this needs to be multiple lines

> WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1399
> +                             || !arguments[4].isBool() || !arguments[5].isNumber())
use {}'s when the if or the subsequent part is more than one line

> WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1402
> +    WebKit::WebDeviceOrientation orientation(arguments[0].toBoolean(), arguments[1].toDouble(),
or this

> WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1406
> +    ASSERT(m_deviceOrientationClientMock.get());
dont need .get() I'm pretty sure

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.