[Webkit-unassigned] [Bug 42612] DRT should allow test scripts to access WebCore internal states for setup/verification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42612





--- Comment #30 from MORITA Hajime <morrita at google.com>  2010-09-09 02:09:22 PST ---
Hi everyone!

I'd like to restart this effort.
I'm sorry that old patches were too large and did a big change.
An latest patch is get further simple, thus small.
I'm happy if you took a look at this one.

The approach is based on Darin's advice, with Adam's concern in mind:

- The WebCore::LayoutTestController is under testing/ directory.
   And the rest of WebCore NEVER depend on the code under testing/
   So its isolation is clear and hard to accidentally available from browsers,
   even though it lives in WebCore.framework and can take its advantage. 

- testing/ module expose just one API (per JS engine) that 
   instantiates WebCore::LTC and injects its method into given JS object 
   using a delegation. 
   This approach doesn't use JSC-specifi mechanism
   and relatively interpreter neutral.

- DumpRenderTree just invokes that API to make WebCore::LTC available.
   So integration to each DRT implementation will be easy.

Any feedback is welcome!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.