[Webkit-unassigned] [Bug 45408] Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests

Thu Sep 9 00:35:14 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45408

Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66935|review?                     |review+
               Flag|                            |

--- Comment #2 from Ojan Vafai <ojan at chromium.org>  2010-09-09 00:35:14 PST ---
(From update of attachment 66935)
View in context: https://bugs.webkit.org/attachment.cgi?id=66935&action=prettypatch

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:64
> +            # Shouldn't happen
If this shouldn't happen, lets just leave out the try/except clause. Otherwise, if this starts happening, we'll never know. I'd be OK with the try/except clause if we logged the error (i.e. a warning level log). But, we shouldn't just silently ignore it.

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:820
>                                     individual_test_timings)
Indentation is off by a space.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.