[Webkit-unassigned] [Bug 45287] [chromium] Leak in RenderViewTest::SimulateElementClick()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45287


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66787|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-09-08 23:30:25 PST ---
(From update of attachment 66787)
View in context: https://bugs.webkit.org/attachment.cgi?id=66787&action=prettypatch

> WebKit/chromium/public/WebDOMEvent.h:55
> +    virtual ~WebDOMEvent() { reset(); }
nit: please list the destructor first w/ a new line between it and WebDOMEvent (as is done in WebNode.h).

I'm also not sure why this destructor needs to be virtual.  This adds a virtual table to this class.  I notice that WebNode also has a virtual destructor, but I can't figure out why it should need one either.

R=me, but please consider making the above changes before committing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.