[Webkit-unassigned] [Bug 45092] [chromium] Accelerated Compositing: screen garbage when scrolling
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 8 16:04:39 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=45092
Vangelis Kokkevis <vangelis at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66828|1 |0
is obsolete| |
--- Comment #20 from Vangelis Kokkevis <vangelis at chromium.org> 2010-09-08 16:04:39 PST ---
(From update of attachment 66828)
View in context: https://bugs.webkit.org/attachment.cgi?id=66828&action=prettypatch
Just a couple of random nits on my side.
> WebCore/platform/graphics/chromium/LayerRendererChromium.h:64
> + // updates size of root texture, if needed, and scrolls the backbuffer
Descriptions need to start with a capital letter and end in a period. Here and below.
> WebKit/chromium/src/WebViewImpl.cpp:2169
> + // Compute the region we will expose by scrolling We use the
Missing period after "scrolling"
> WebKit/chromium/src/WebViewImpl.cpp:2204
> + // so that invalidations and scroll invalidations play well with one-another.
this comment should probably move down, to right above the point where you do the actual conversion.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list