[Webkit-unassigned] [Bug 45247] [EFL] Need to add custom dependencies.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45247





--- Comment #8 from Ryuan Choi <ryuan.choi at samsung.com>  2010-09-08 07:40:24 PST ---
(In reply to comment #7)
> Created an attachment (id=66897)
 --> (https://bugs.webkit.org/attachment.cgi?id=66897) [details]
> Patch

(In reply to comment #6)
> (In reply to comment #5)
> > 
> > thank you.
> > I created patch like you mentioned.
> 
> 
> Humn, sorry. Looking again at this issue, I think a much cleaner approach would be to apply the following patch. It just adds the theme to WebKit's source list.
> 
> Leandro, Ryuan, what do you think?
> 
> 
> diff --git a/WebKit/efl/CMakeListsEfl.txt b/WebKit/efl/CMakeListsEfl.txt
> index cff1822..57cacae 100644
> --- a/WebKit/efl/CMakeListsEfl.txt
> +++ b/WebKit/efl/CMakeListsEfl.txt
> @@ -159,6 +159,10 @@ ADD_CUSTOM_COMMAND(
>    VERBATIM
>  )
> 
> +LIST(APPEND WebKit_SOURCES
> +     ${WebKit_THEME}
> +)
> +
>  IF (SHARED_CORE)
>      SET(LIBS_PRIVATE "-l${WTF_LIBRARY_NAME} -l${JavaScriptCore_LIBRARY_NAME} -l${WebCore_LIBRARY_NAME}")
>  ELSE ()

LGTM,
Conceptually, it's not a source. but it's simple than before.
I tested and upload patch you mentioned.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.