[Webkit-unassigned] [Bug 45286] Web Inspector: use string representation of resource type in extension API

Wed Sep 8 07:05:28 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=45286

Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66712|review?                     |review-
               Flag|                            |

--- Comment #5 from Yury Semikhatsky <yurys at chromium.org>  2010-09-08 07:05:28 PST ---
(From update of attachment 66712)
View in context: https://bugs.webkit.org/attachment.cgi?id=66712&action=prettypatch

> LayoutTests/inspector/extensions-resources.html:47
> +    webInspector.inspectedWindow.evaluate("var xhr = new XMLHttpRequest(); xhr.open('GET', '" + location.href + "', false); xhr.send(null);", callback);
This code can be extracted into a function on the inspected side and then you would only need to call that function. I guess it might make the code more clear.

> WebCore/inspector/front-end/ExtensionAPI.js:134
> +var ResourceTypes = {
Could we extract this into a file shared between ExtensionAPI.js and Resource.js, r- for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.