[Webkit-unassigned] [Bug 45261] [NRWT] Add temp directory to all running drivers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 8 05:15:46 PDT 2010


--- Comment #7 from Gabor Rapcsanyi <rgabor at inf.u-szeged.hu>  2010-09-08 05:15:45 PST ---
(In reply to comment #6)
> Hmm. It's not great that we're doing this work in the constructor and destructor; I've found that can lead to indeterminate results in general (although it's fine in this case).
> There's actually a port.setup_test_run() method that would be the appropriate place to create the temp dir - it's called only when we're sure we actually want to start running tests, but before DumpRenderTree is ever launched. Unfortunately, there isn't a cleanup_test_run() method to match it.
> I'll add both of those and refactor this (in a separate bug/change), unless there's an objection ...

Ok, you're right. We don't know when the gc delete this temp directory, so maybe a better way is your idea.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list