[Webkit-unassigned] [Bug 45377] Errors in LayoutTests/http/tests/security/xss-DENIED-mime-type-execute-as-html.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45377


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66866|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2010-09-08 03:46:05 PST ---
(From update of attachment 66866)
View in context: https://bugs.webkit.org/attachment.cgi?id=66866&action=prettypatch

Please add more detail to the ChangeLog before landing.

> LayoutTests/ChangeLog:7
> +        Errors in LayoutTests/http/tests/security/xss-DENIED-mime-type-execute-as-html.html
> +        https://bugs.webkit.org/show_bug.cgi?id=45377
> +
It would be better if your ChangeLog explains what problem this patch solves.  "Errors" is a pretty general problem.  You explained it to me over IRC, but someone reading this ChangeLog will be pretty mystified.

> LayoutTests/http/tests/security/resources/send-mime-types.php:2
> -    $mime_type = urldecode($_GET["mt"]);
> +    $mime_type = $_GET["mt"];
Yeah, the old code is pretty confused, huh?

> LayoutTests/http/tests/security/xss-DENIED-mime-type-execute-as-html.html:19
> -  ifr.src = "http://localhost:8000/security/resources/send-mime-types.php?mt=" + escape(mime_types[i]);
> +  ifr.src = "http://localhost:8000/security/resources/send-mime-types.php?mt=" + encodeURIComponent(mime_types[i]);
Did this change actually make a difference?  It seems like the other change is probably the operative one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.