[Webkit-unassigned] [Bug 44954] [WML] Remove create() function in WMLTaskElement because of build breaks.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44954


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66054|0                           |1
        is obsolete|                            |
  Attachment #66837|                            |review?, commit-queue?
               Flag|                            |




--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-09-07 20:26:36 PST ---
Created an attachment (id=66837)
 --> (https://bugs.webkit.org/attachment.cgi?id=66837)
Patch

When I modify this patch with your guidance, there are no build break.
As you know, the build break came from the create(). So, if we remove the create() in WMLTaskElement.cpp, I think we should find which class uses the create() function. But, I can't find classes which invokes the create() from WMLTaskElement.cpp. 

>> I'm also confused, that we don't have 'create' for the elements mentioned above (Go, Prev, Refresh).

The three elements you mentioned have create() functions as below. The create() of WMLTaskCreate is not invoked by other classes. If we need to make the create() function for WMLTaskElement, I think we can make it again. For now, this patch is needed to fix build break. How do you think about it ?


================================================================================================
 53 PassRefPtr<WMLGoElement> WMLGoElement::create(const QualifiedName& tagName, Document* document)
 54 {

 39 PassRefPtr<WMLPrevElement> WMLPrevElement::create(const QualifiedName& tagName, Document* document)
 40 {

 40 PassRefPtr<WMLRefreshElement> WMLRefreshElement::create(const QualifiedName& tagName, Document* document)
 41 {
================================================================================================

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.