[Webkit-unassigned] [Bug 45344] Null deref in InlineBox::height()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45344





--- Comment #3 from James Robinson <jamesr at chromium.org>  2010-09-07 18:26:29 PST ---
(From update of attachment 66812)
View in context: https://bugs.webkit.org/attachment.cgi?id=66812&action=prettypatch

> WebCore/rendering/InlineBox.cpp:99
> +    if (!renderer()->style(m_firstLine))
> +        return 0;
>      if (renderer()->isText())
>          return m_isText ? renderer()->style(m_firstLine)->font().height() : 0;
>      if (renderer()->isBox() && parent())
There's one very slight behavior change here - if renderer()->isBox() && parent() == true, old code wouldn't call renderer()->style(m_firstLine) at all whereas this patch will.  Can you reoranize this so that's still true?  I think moving the isBox() && ... branch above the NULL check will suffice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.