[Webkit-unassigned] [Bug 45077] Add EqualPowerPanner files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45077





--- Comment #2 from Kenneth Russell <kbr at google.com>  2010-09-07 17:44:03 PST ---
(From update of attachment 66307)
View in context: https://bugs.webkit.org/attachment.cgi?id=66307&action=prettypatch

> WebCore/platform/audio/EqualPowerPanner.cpp:85
> +    const double kDezipperK = 0.0005;
This or similar constants are replicated in a few places in the code, for example in the AudioBus (where it's ten times as large). Can this be refactored? Also, what about a FIXME indicating that it's sample rate dependent?

> WebCore/platform/audio/EqualPowerPanner.cpp:98
> +    m_gainR = gainR;
Why does this class not need to expose these gains externally, like the AudioBus does via the lastMixGain outgoing argument in processWithGainFromMonoStereo and processWithGainFrom?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.