[Webkit-unassigned] [Bug 45204] Add AudioArray.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45204


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66547|review?                     |review+
               Flag|                            |




--- Comment #2 from Kenneth Russell <kbr at google.com>  2010-09-07 17:30:22 PST ---
(From update of attachment 66547)
Looks good to me. One comment not necessarily requiring action.

View in context: https://bugs.webkit.org/attachment.cgi?id=66547&action=prettypatch

> WebCore/platform/audio/AudioArray.h:55
> +    void copyToRange(T* sourceData, unsigned start, unsigned end)
If you have situations elsewhere in your code where you would pass e.g. AudioFloatArray.data() as the first argument to copyToRange, then it would be good to add another overloaded version of copyToRange which can also verify that the source array has enough elements to cover the copy operation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.