[Webkit-unassigned] [Bug 45315] Enable incremental results.json generation for non-layout tests.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45315


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66748|review?                     |review+
               Flag|                            |




--- Comment #3 from Ojan Vafai <ojan at chromium.org>  2010-09-07 17:07:33 PST ---
(From update of attachment 66748)
View in context: https://bugs.webkit.org/attachment.cgi?id=66748&action=prettypatch

Just a few nits.

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:296
> +                print results_file_url
Did you mean to include this?

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:532
> +                    self._builder_name, self._test_results_server)
Indentation is off. Have a couple extra spaces.

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:595
> +        # Generate the JSON with incrementa flag enabled.
Typo: incrementa

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.