[Webkit-unassigned] [Bug 45331] [Qt] Calling Path::closeSubpath() when the path only contains only one line or curve element does not result in the path being closed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45331


Andreas Kling <andreas.kling at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66782|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Andreas Kling <andreas.kling at nokia.com>  2010-09-07 16:41:21 PST ---
(From update of attachment 66782)
> +#if PLATFORM(QT)
> +        m_path.closeCanvasSubpath();
> +#else
>          m_path.closeSubpath();
> +#endif

It's rather un-obvious why we're doing something differently on Qt here.

I think all platforms should have closeCanvasSubpath() and we'd call that from here instead.

For non-Qt ports, it could be an inline call to closeSubpath() in Path.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.