[Webkit-unassigned] [Bug 37369] [GTK] Enable building whatever already exists of WebKit2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 7 14:32:08 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=37369





--- Comment #16 from Xan Lopez <xan.lopez at gmail.com>  2010-09-07 14:32:07 PST ---
(From update of attachment 63386)
> distclean-local:
>-	-rm -rf $(GENSOURCES) $(GENPROGRAMS)
>+	-rm -rf $(GENSOURCES) $(GENPROGRAMS) include

Does the include dir need to be in the toplevel actually? I also wonder if there's some way to move that into the WebKit2 makefile. I suppose defining the rule multiple times won't do the right thing ;)

>+libwebkit2_la_CXXFLAGS = \
>+	$(global_cxxflags) \
>+	$(corekit_cflags)
>+
>+libwebkit2_la_CFLAGS = \
>+	$(global_cflags) \
>+	$(corekit_cflags)

I believe corekit_cflags does not exist anymore?

>+
>+# Ensure that the prefix header is built before
>+BUILT_SOURCES += \
>+	$(webkit2_copied_headers) \
>+	DerivedSources/WebKit2/WebKit2Prefix.h.gch
>+


>+# We compile the prefix header into a precompiled header in the DerivedSources
>+# directory, so we can force it to be at the beginning of the include list.
>+DerivedSources/WebKit2/WebKit2Prefix.h.gch: $(srcdir)/WebKit2/WebKit2Prefix.h
>+	mkdir -p DerivedSources/WebKit2
>+	cp -u $< DerivedSources/WebKit2/WebKit2Prefix.h
>+	$(CXXCOMPILE) $(libwebkit2_la_CPPFLAGS) -c DerivedSources/WebKit2/WebKit2Prefix.h

Should use AM_V_GEN there.

>+
>+javascriptcore_headers := $(filter %.h, $(javascriptcore_sources))
>+copy-javascriptcore-headers: $(javascriptcore_headers)
>+	mkdir -p include/JavaScriptCore
>+	cp -u $(foreach include,$(javascriptcore_headers),$(srcdir)/$(include)) include/JavaScriptCore

And there.

>+phony_targets += copy-javascriptcore-headers
>+
>+webcore_headers := $(filter %.h, $(webcore_sources))
>+copy-webcore-headers: $(webcore_headers)
>+	mkdir -p include/WebCore
>+	cp -u $(foreach include,$(webcore_headers),$(srcdir)/$(include)) include/WebCore

Same.

>+phony_targets += copy-webcore-headers
>+

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list