[Webkit-unassigned] [Bug 45190] [Gtk] A list item's number/bullet should not be a child of that list item

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45190


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66728|0                           |1
        is obsolete|                            |
  Attachment #66761|                            |review?
               Flag|                            |




--- Comment #5 from Mario Sanchez Prada <msanchez at igalia.com>  2010-09-07 13:49:58 PST ---
Created an attachment (id=66761)
 --> (https://bugs.webkit.org/attachment.cgi?id=66761)
Patch + unit test

(In reply to comment #4)
> (From update of attachment 66728 [details])
> I think this is OK. Joanie and you should work towards writing actual layout or unit tests for this stuff 
> instead of manual testcases for each bug. Seems a waste not to do that since she's already writing 
> one test per bug she opens most of the time.

Understood. Now replacing the former patch with another one including the same code *plus* a new unit test to check everything is working as expected (inspired in Joanie's test case).

Btw, if you review+ this new patch don't forget to put the commit-queue+ flag as well, since I'm not a committer and I can't commit patches on my own.

Thanks for reviewing and sorry for the hassle

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.