[Webkit-unassigned] [Bug 44127] [chromium] Thumbnails not generated for GPU Rendered Pages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44127





--- Comment #54 from W. James MacLean <wjmaclean at chromium.org>  2010-09-07 13:19:22 PST ---
(In reply to comment #52)
> (From update of attachment 66521 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=66521&action=prettypatch
> 
> > WebKit/chromium/src/WebViewImpl.cpp:1017
> > +                SkIRect srcRect(IntRect(IntPoint(), rect.size()));
> It was pointed out to me that the semantics of the WebViewImpl::paint() method call for the rect to be painted on the WebCanvas with the same offset it was grabbed from. In other words, the dest rect must be the same as the source rect. Sorry about the confusion!

Fixed. The line of code you quote above needs to stay as is, as srcRect refers to the temporary bitmap we allocate to handle the (potential) size difference, but the next line (dstRect) changes.

I've also put the vertical-flip code inside a PLATFORM(SKIA) block since
1) CG doesn't need it flipped, so if we leave it in a secondary transform is required,
2) the secondary transform screws up if 'rect' is a sub-set of the canvas, and
3) and it's faster for Mac.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.