[Webkit-unassigned] [Bug 45192] Provide a way to trigger a <select multiple> onchange event on changes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45192


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66570|review?                     |review-
               Flag|                            |




--- Comment #18 from Darin Adler <darin at apple.com>  2010-09-07 13:18:44 PST ---
(From update of attachment 66570)
Great to add a test for this!

This DOMHTMLController object doesn’t seem to have too much to do with DOM, except inasmuch all JavaScript functions are part of "DOM". We have lots of functions like this on the main layout test controller. I’m not sure why we are making a new object for these functions. For example, the execCommand, isCommandEnabled, elementDoesAutoCompleteForElementWithId, counterValueForElementById, computedStyleIncludingVisitedInfo, and markerTextForListItem functions.

Maybe it would be better to make this part of a "form testing" controller, or a "user input simulating" type controller, or maybe make it part of LayoutTestController since many other functions like this are already there.

HTML should be in all caps (or all lower case in strange cases), not spelled "Html".

The DOM prefix is reserved for WebKit use for the Objective-C DOM bindings, so it’s not great to have DumpRenderTree use this prefix for one of its classes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.