[Webkit-unassigned] [Bug 42781] WebKit2 needs undo/redo support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42781





--- Comment #7 from Sam Weinig <sam at webkit.org>  2010-09-07 12:09:11 PST ---
> > 
> > > +    WebProcess::shared().connection()->send(WebPageProxyMessage::RegisterEditCommandForUndo, m_page->pageID(),
> > > +                                            CoreIPC::In(webCommand->commandID(), static_cast<uint32_t>(webCommand->command()->editingAction())));
> > 
> > We normally don't like things up like this in WebKit code, since the alignment gets screwed up if we rename something. Is there any clean way to avoid the static_cast? Maybe a local variable instead?
> 
> We have been doing this a bit in WebKit2.  We should definitely look at all the places we do it and fix them.

Never mind. I misunderstood this. Moved into local.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.